Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove using namespace std and use std namespace explicitly #2125

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

bashbaug
Copy link
Contributor

Removes using namespace std and adds std:: explicitly instead, which is usually on calls to min.

This is generally best practice, and it also might be helpful when there are the same function names in the std namespace and in the global namespace (e.g. #1833).

@bashbaug
Copy link
Contributor Author

@lakshmih any concerns? Maybe we can merge this offline?

@bashbaug
Copy link
Contributor Author

Merging as discussed in the October 29th teleconference.

@bashbaug bashbaug merged commit d8228f0 into KhronosGroup:main Oct 29, 2024
7 checks passed
@bashbaug bashbaug deleted the no-namespace-std branch October 29, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants